find-node.sh supports Homebrew on M1 #31622
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
38 tasks
|
@kelset should we cherry pick this to 0.64? |
Base commit: 118489f |
yeah that's a good idea, we need to get this merged first thought 😓 |
14 tasks
|
@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
kelset
pushed a commit
that referenced
this pull request
Jun 3, 2021
Summary: Homebrew on M1 installs executable binaries in **/opt/homebrew/bin** (See https://brew.sh/2021/02/05/homebrew-3.0.0/), and FBReactNativeSpec.build is failing because it couldn't find node. This PR changes find-node.sh script to add /opt/homebrew/bin into $PATH. The way **react.gradle** trying to execute node is not using user environment variables, but system defaults, so it couldn't find it. I removed node execution, and hard coded cli path in parity with iOS https://github.com/facebook/react-native/blob/d1ab03235cb4b93304150878d2b9057ab45bba77/scripts/react-native-xcode.sh#L106 Fixes #31621 #31592 ## Changelog [General] [Changed] - find-node.sh supports Homebrew on M1 Pull Request resolved: #31622 Test Plan: On M1, create a RN project and it'll fail to build iOS app. Apply the patch, and build will succeed. Reviewed By: ShikaSD Differential Revision: D28808206 Pulled By: hramos fbshipit-source-id: 8b313b6685462a15e67d99c61a0202d17fece1ec # Conflicts: # scripts/find-node.sh
Titozzz
pushed a commit
to Titozzz/react-native
that referenced
this pull request
Jun 7, 2021
Summary: Homebrew on M1 installs executable binaries in **/opt/homebrew/bin** (See https://brew.sh/2021/02/05/homebrew-3.0.0/), and FBReactNativeSpec.build is failing because it couldn't find node. This PR changes find-node.sh script to add /opt/homebrew/bin into $PATH. The way **react.gradle** trying to execute node is not using user environment variables, but system defaults, so it couldn't find it. I removed node execution, and hard coded cli path in parity with iOS https://github.com/facebook/react-native/blob/d1ab03235cb4b93304150878d2b9057ab45bba77/scripts/react-native-xcode.sh#L106 Fixes facebook#31621 facebook#31592 ## Changelog [General] [Changed] - find-node.sh supports Homebrew on M1 Pull Request resolved: facebook#31622 Test Plan: On M1, create a RN project and it'll fail to build iOS app. Apply the patch, and build will succeed. Reviewed By: ShikaSD Differential Revision: D28808206 Pulled By: hramos fbshipit-source-id: 8b313b6685462a15e67d99c61a0202d17fece1ec
Titozzz
pushed a commit
to Titozzz/react-native
that referenced
this pull request
Jun 7, 2021
Summary: Homebrew on M1 installs executable binaries in **/opt/homebrew/bin** (See https://brew.sh/2021/02/05/homebrew-3.0.0/), and FBReactNativeSpec.build is failing because it couldn't find node. This PR changes find-node.sh script to add /opt/homebrew/bin into $PATH. The way **react.gradle** trying to execute node is not using user environment variables, but system defaults, so it couldn't find it. I removed node execution, and hard coded cli path in parity with iOS https://github.com/facebook/react-native/blob/d1ab03235cb4b93304150878d2b9057ab45bba77/scripts/react-native-xcode.sh#L106 Fixes facebook#31621 facebook#31592 ## Changelog [General] [Changed] - find-node.sh supports Homebrew on M1 Pull Request resolved: facebook#31622 Test Plan: On M1, create a RN project and it'll fail to build iOS app. Apply the patch, and build will succeed. Reviewed By: ShikaSD Differential Revision: D28808206 Pulled By: hramos fbshipit-source-id: 8b313b6685462a15e67d99c61a0202d17fece1ec
|
@dulmandakh sadly this fix is incorrect when using nvm on m1. The order in find-node.sh is wrong. If you put the |
|
Sorry, I don't use nvm and have no experience, also didn't wanted to mess with someones setup. Please create a PR, I would be happy to review it. Thanks |
tido64
pushed a commit
that referenced
this pull request
Jun 8, 2021
Summary: Homebrew on M1 installs executable binaries in **/opt/homebrew/bin** (See https://brew.sh/2021/02/05/homebrew-3.0.0/), and FBReactNativeSpec.build is failing because it couldn't find node. This PR changes find-node.sh script to add /opt/homebrew/bin into $PATH. The way **react.gradle** trying to execute node is not using user environment variables, but system defaults, so it couldn't find it. I removed node execution, and hard coded cli path in parity with iOS https://github.com/facebook/react-native/blob/d1ab03235cb4b93304150878d2b9057ab45bba77/scripts/react-native-xcode.sh#L106 Fixes #31621 #31592 ## Changelog [General] [Changed] - find-node.sh supports Homebrew on M1 Pull Request resolved: #31622 Test Plan: On M1, create a RN project and it'll fail to build iOS app. Apply the patch, and build will succeed. Reviewed By: ShikaSD Differential Revision: D28808206 Pulled By: hramos fbshipit-source-id: 8b313b6685462a15e67d99c61a0202d17fece1ec
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 8, 2021
Summary: Adds homebrew on m1 to path before evaluating `command -v brew` to support nvm on m1 via homebrew. ## Changelog [General] [Changed] - Find node on m1 via homebrew node managers Pull Request resolved: #31678 Test Plan: On M1, use nvm via homebrew. Create a RN project and it'll fail to build iOS app. Apply the patch, and build will succeed. cc: dulmandakh as discussed in #31622 Reviewed By: ShikaSD Differential Revision: D28967386 Pulled By: PeteTheHeat fbshipit-source-id: 3d4a41dd3cc25fbf77778b16468a236b141d1259
danilobuerger
pushed a commit
to feastr/react-native
that referenced
this pull request
Jun 9, 2021
Summary: Homebrew on M1 installs executable binaries in **/opt/homebrew/bin** (See https://brew.sh/2021/02/05/homebrew-3.0.0/), and FBReactNativeSpec.build is failing because it couldn't find node. This PR changes find-node.sh script to add /opt/homebrew/bin into $PATH. The way **react.gradle** trying to execute node is not using user environment variables, but system defaults, so it couldn't find it. I removed node execution, and hard coded cli path in parity with iOS https://github.com/facebook/react-native/blob/d1ab03235cb4b93304150878d2b9057ab45bba77/scripts/react-native-xcode.sh#L106 Fixes facebook#31621 facebook#31592 [General] [Changed] - find-node.sh supports Homebrew on M1 Pull Request resolved: facebook#31622 Test Plan: On M1, create a RN project and it'll fail to build iOS app. Apply the patch, and build will succeed. Reviewed By: ShikaSD Differential Revision: D28808206 Pulled By: hramos fbshipit-source-id: 8b313b6685462a15e67d99c61a0202d17fece1ec
danilobuerger
added a commit
to feastr/react-native
that referenced
this pull request
Jun 9, 2021
Summary: Adds homebrew on m1 to path before evaluating `command -v brew` to support nvm on m1 via homebrew. ## Changelog [General] [Changed] - Find node on m1 via homebrew node managers Pull Request resolved: facebook#31678 Test Plan: On M1, use nvm via homebrew. Create a RN project and it'll fail to build iOS app. Apply the patch, and build will succeed. cc: dulmandakh as discussed in facebook#31622 Reviewed By: ShikaSD Differential Revision: D28967386 Pulled By: PeteTheHeat fbshipit-source-id: 3d4a41dd3cc25fbf77778b16468a236b141d1259
kelset
pushed a commit
that referenced
this pull request
Jun 16, 2021
Summary: Adds homebrew on m1 to path before evaluating `command -v brew` to support nvm on m1 via homebrew. ## Changelog [General] [Changed] - Find node on m1 via homebrew node managers Pull Request resolved: #31678 Test Plan: On M1, use nvm via homebrew. Create a RN project and it'll fail to build iOS app. Apply the patch, and build will succeed. cc: dulmandakh as discussed in #31622 Reviewed By: ShikaSD Differential Revision: D28967386 Pulled By: PeteTheHeat fbshipit-source-id: 3d4a41dd3cc25fbf77778b16468a236b141d1259
Setito
pushed a commit
to Setito/react-native
that referenced
this pull request
Jul 17, 2021
Summary: Homebrew on M1 installs executable binaries in **/opt/homebrew/bin** (See https://brew.sh/2021/02/05/homebrew-3.0.0/), and FBReactNativeSpec.build is failing because it couldn't find node. This PR changes find-node.sh script to add /opt/homebrew/bin into $PATH. The way **react.gradle** trying to execute node is not using user environment variables, but system defaults, so it couldn't find it. I removed node execution, and hard coded cli path in parity with iOS https://github.com/facebook/react-native/blob/d1ab03235cb4b93304150878d2b9057ab45bba77/scripts/react-native-xcode.sh#L106 Fixes facebook#31621 facebook#31592 ## Changelog [General] [Changed] - find-node.sh supports Homebrew on M1 Pull Request resolved: facebook#31622 Test Plan: On M1, create a RN project and it'll fail to build iOS app. Apply the patch, and build will succeed. Reviewed By: ShikaSD Differential Revision: D28808206 Pulled By: hramos fbshipit-source-id: 8b313b6685462a15e67d99c61a0202d17fece1ec
danilobuerger
pushed a commit
to feastr/react-native
that referenced
this pull request
Oct 28, 2021
Summary: Homebrew on M1 installs executable binaries in **/opt/homebrew/bin** (See https://brew.sh/2021/02/05/homebrew-3.0.0/), and FBReactNativeSpec.build is failing because it couldn't find node. This PR changes find-node.sh script to add /opt/homebrew/bin into $PATH. The way **react.gradle** trying to execute node is not using user environment variables, but system defaults, so it couldn't find it. I removed node execution, and hard coded cli path in parity with iOS https://github.com/facebook/react-native/blob/d1ab03235cb4b93304150878d2b9057ab45bba77/scripts/react-native-xcode.sh#L106 Fixes facebook#31621 facebook#31592 [General] [Changed] - find-node.sh supports Homebrew on M1 Pull Request resolved: facebook#31622 Test Plan: On M1, create a RN project and it'll fail to build iOS app. Apply the patch, and build will succeed. Reviewed By: ShikaSD Differential Revision: D28808206 Pulled By: hramos fbshipit-source-id: 8b313b6685462a15e67d99c61a0202d17fece1ec
danilobuerger
added a commit
to feastr/react-native
that referenced
this pull request
Oct 28, 2021
Summary: Adds homebrew on m1 to path before evaluating `command -v brew` to support nvm on m1 via homebrew. ## Changelog [General] [Changed] - Find node on m1 via homebrew node managers Pull Request resolved: facebook#31678 Test Plan: On M1, use nvm via homebrew. Create a RN project and it'll fail to build iOS app. Apply the patch, and build will succeed. cc: dulmandakh as discussed in facebook#31622 Reviewed By: ShikaSD Differential Revision: D28967386 Pulled By: PeteTheHeat fbshipit-source-id: 3d4a41dd3cc25fbf77778b16468a236b141d1259
danilobuerger
pushed a commit
to feastr/react-native
that referenced
this pull request
Oct 28, 2021
Summary: Homebrew on M1 installs executable binaries in **/opt/homebrew/bin** (See https://brew.sh/2021/02/05/homebrew-3.0.0/), and FBReactNativeSpec.build is failing because it couldn't find node. This PR changes find-node.sh script to add /opt/homebrew/bin into $PATH. The way **react.gradle** trying to execute node is not using user environment variables, but system defaults, so it couldn't find it. I removed node execution, and hard coded cli path in parity with iOS https://github.com/facebook/react-native/blob/d1ab03235cb4b93304150878d2b9057ab45bba77/scripts/react-native-xcode.sh#L106 Fixes facebook#31621 facebook#31592 [General] [Changed] - find-node.sh supports Homebrew on M1 Pull Request resolved: facebook#31622 Test Plan: On M1, create a RN project and it'll fail to build iOS app. Apply the patch, and build will succeed. Reviewed By: ShikaSD Differential Revision: D28808206 Pulled By: hramos fbshipit-source-id: 8b313b6685462a15e67d99c61a0202d17fece1ec
danilobuerger
added a commit
to feastr/react-native
that referenced
this pull request
Oct 28, 2021
Summary: Adds homebrew on m1 to path before evaluating `command -v brew` to support nvm on m1 via homebrew. ## Changelog [General] [Changed] - Find node on m1 via homebrew node managers Pull Request resolved: facebook#31678 Test Plan: On M1, use nvm via homebrew. Create a RN project and it'll fail to build iOS app. Apply the patch, and build will succeed. cc: dulmandakh as discussed in facebook#31622 Reviewed By: ShikaSD Differential Revision: D28967386 Pulled By: PeteTheHeat fbshipit-source-id: 3d4a41dd3cc25fbf77778b16468a236b141d1259
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Homebrew on M1 installs executable binaries in /opt/homebrew/bin (See https://brew.sh/2021/02/05/homebrew-3.0.0/), and FBReactNativeSpec.build is failing because it couldn't find node. This PR changes find-node.sh script to add /opt/homebrew/bin into $PATH.
The way react.gradle trying to execute node is not using user environment variables, but system defaults, so it couldn't find it. I removed node execution, and hard coded cli path in parity with iOS
react-native/scripts/react-native-xcode.sh
Line 106 in d1ab032
Fixes #31621 #31592
Changelog
[General] [Changed] - find-node.sh supports Homebrew on M1
Test Plan
On M1, create a RN project and it'll fail to build iOS app. Apply the patch, and build will succeed.